-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect font image for Gohu & Proggy on main website #489
Comments
Thanks for reporting! I think I recreated the images in 2021, maybe you want to check if they are still wrong? |
Glad to hear an update. :D Unfortunately, they are still probably displayed as a fallback font. The case is also true for ProggyClean. Could be an issue with bitmap fonts. There has been a couple of foundamental changes in the recent years regarding how bitmap fonts are taken care of. Anyway, given the fonts popularity, I don't think this is a big issue. |
Family name of image preview font is wrong, that means fallback ... :-( Was there not a warning if fallback occurs? The Family name is Edit: There is a warning and always has been 3444b57 |
[why] Some font previews in the gh-pages are obviously wrong (showing some fallback font). [how] Recreate all image previes from current master branch. To make this more easy: - Add commented out code that displays command to install just the needed fonts but all the needed fonts - Add commented out code that displays the family names of the needed fonts - these have to be in sync with the fonts.json database Fixes: #489 Reported-by: CosmosAtlas Signed-off-by: Fini Jastrow <[email protected]>
[why] Some font previews in the gh-pages are obviously wrong (showing some fallback font). [how] Recreate all image previes from current master branch. To make this more easy: - Add commented out code that displays command to install just the needed fonts but all the needed fonts - Add commented out code that displays the family names of the needed fonts - these have to be in sync with the fonts.json database Fixes: #489 Reported-by: CosmosAtlas Signed-off-by: Fini Jastrow <[email protected]>
Thanks for reporting and your persistence that finally fixed this 🎉 |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
[why] Some font previews in the gh-pages are obviously wrong (showing some fallback font). [how] Recreate all image previes from current master branch. To make this more easy: - Add commented out code that displays command to install just the needed fonts but all the needed fonts - Add commented out code that displays the family names of the needed fonts - these have to be in sync with the fonts.json database Fixes: ryanoasis#489 Reported-by: CosmosAtlas Signed-off-by: Fini Jastrow <[email protected]>
🎯 Incorrect font image for Gohu & Proggy on main website
On the main website's download page: https://www.nerdfonts.com/font-downloads
For each font supported, a preview image is also provided. However, for some bitmap fonts, mainly Gohu and Proggy, the preview is clearly not how the font look like.
★ Optional
Gohu font preview on downloads page
Preview on main website
What Gohu font actually look like
on source website
My thoughts on why it happen
Probably some font rendering issue when generating these previews.
The text was updated successfully, but these errors were encountered: