Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect font image for Gohu & Proggy on main website #489

Closed
CosmosAtlas opened this issue Jun 15, 2020 · 5 comments · Fixed by #1093
Closed

Incorrect font image for Gohu & Proggy on main website #489

CosmosAtlas opened this issue Jun 15, 2020 · 5 comments · Fixed by #1093

Comments

@CosmosAtlas
Copy link

🎯 Incorrect font image for Gohu & Proggy on main website

On the main website's download page: https://www.nerdfonts.com/font-downloads

For each font supported, a preview image is also provided. However, for some bitmap fonts, mainly Gohu and Proggy, the preview is clearly not how the font look like.

★ Optional

Gohu font preview on downloads page
Preview on main website

What Gohu font actually look like
on source website

My thoughts on why it happen

Probably some font rendering issue when generating these previews.

@Finii
Copy link
Collaborator

Finii commented Jan 28, 2023

Thanks for reporting!

I think I recreated the images in 2021, maybe you want to check if they are still wrong?

@Finii Finii closed this as completed Jan 28, 2023
@CosmosAtlas
Copy link
Author

Glad to hear an update. :D

Unfortunately, they are still probably displayed as a fallback font. The case is also true for ProggyClean.

Could be an issue with bitmap fonts. There has been a couple of foundamental changes in the recent years regarding how bitmap fonts are taken care of.

Anyway, given the fonts popularity, I don't think this is a big issue.

@Finii Finii reopened this Jan 29, 2023
@Finii
Copy link
Collaborator

Finii commented Jan 29, 2023

Family name of image preview font is wrong, that means fallback ... :-(

Was there not a warning if fallback occurs?

image

The Family name is ProggyCleanTT Nerd Font.

image

Edit: There is a warning and always has been 3444b57

Finii added a commit that referenced this issue Jan 30, 2023
[why]
Some font previews in the gh-pages are obviously wrong (showing some
fallback font).

[how]
Recreate all image previes from current master branch.

To make this more easy:
- Add commented out code that displays command to install just the
  needed fonts but all the needed fonts
- Add commented out code that displays the family names of the needed
  fonts - these have to be in sync with the fonts.json database

Fixes: #489

Reported-by: CosmosAtlas
Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii mentioned this issue Jan 30, 2023
2 tasks
Finii added a commit that referenced this issue Jan 30, 2023
[why]
Some font previews in the gh-pages are obviously wrong (showing some
fallback font).

[how]
Recreate all image previes from current master branch.

To make this more easy:
- Add commented out code that displays command to install just the
  needed fonts but all the needed fonts
- Add commented out code that displays the family names of the needed
  fonts - these have to be in sync with the fonts.json database

Fixes: #489

Reported-by: CosmosAtlas
Signed-off-by: Fini Jastrow <[email protected]>
@Finii
Copy link
Collaborator

Finii commented Jan 30, 2023

Thanks for reporting and your persistence that finally fixed this 🎉

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
[why]
Some font previews in the gh-pages are obviously wrong (showing some
fallback font).

[how]
Recreate all image previes from current master branch.

To make this more easy:
- Add commented out code that displays command to install just the
  needed fonts but all the needed fonts
- Add commented out code that displays the family names of the needed
  fonts - these have to be in sync with the fonts.json database

Fixes: ryanoasis#489

Reported-by: CosmosAtlas
Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants