Patching Monaco and failing. No correct glyphs, non aligned or Powerline symbols too big

[luispuerto]

Subject of the issue

I've been trying all day today to patch correctly Monaco and Menlo Nerd Complete **Mono**, but I've failed spectacularly. I've been trying different options provided by the script but I wasn't able to a correctly display font on my terminal.

First, I've tried to patch the original font from my fonts folder (System/Library/Fonts/), but I wasn't able to make it in a way to display the correct glyphs or correctly aligned.

Then, I found that @taohex already has done the patching, thus I downloaded the fond and tried to transform to mono, the closest thing I've been able to yield is this

As you can see the Powerline extra symbols are slightly bigger than the fond, and I can't figure out how to fix it.

I've got the same result with the Menlo font.

If you can lend me a hand I would be grateful. I also think that, if possible, if you can add those fonts to the repository would be great. Monaco is the default font of rStudio and now it's possible to call the terminal from within the app so I would like to use zsh with nerd fonts to make similar to my setup in iTerm2.

Your Setup

• I'm trying to patch mainly Monaco and also Menlo.
• I use iTerm2 as my main terminal, but I'm trying to patch Monaco because I want to use it on rStudio. I need the fonts in mono because rStudio uses only mono fonts.
• I'm using Mac OS X 10.11.6 El Capitan and I've dowloaded fontforge with homebrew.

[ryanoasis]

@luisspuerto Thanks for the detailed report 👍

So does it look fine in the non-mono form?

You tried using @taohex's patched Monaco but when you try to patch as mono it looks as shown in your screenshot?

[luispuerto]

Hi!!

If I make myself a non-mono form the result is exactly the same to the mono one...

@taohex's patched monaco look's good in iTerm

but mine doesn't

If you look closely... mine is like the height of the line shrinks a little bit. This is the line size of the original Monaco.

It's something that can be noticed in the mac font book app.

Any idea of how to fix?

[luispuerto]

I did the patching on a Raspberry Pi with Raspbian Stretch, coping the Monaco from my Mac, and de result was the same I got when I past directly on my mac. With the wrong glyphs and not correctly aligned...

Besides, I tried to do a second time and give me a lot of error. You can see the log files here:

https://gist.github.com/luisspuerto/8e8e31a8ae6b92b3ba5f855ee2249b99

The output for the same time in the pi was the same as in the mac. In the mac never ever return me an error.

[luispuerto]

PS/ when I saw the un aligned glyphs and the too big Powerline symbols I also tried the -l flag with even worse result. I also checked if the problem was my Monaco font file. I downloaded @taohex's one but I got the same result. I guess it's the same as mine since the size is exactly the same. Anyway, you can download mine here Monaco.dfont.zip

[ryanoasis]

@luisspuerto This is just a shot in the dark but what if you try the --adjust-line-height flag?

[luispuerto]

I think I've already tried... but I can try again.

[luispuerto]

the result is even worse.

First screenshot if with the original Monaco and second is with @taohex's. The result is the same.

But the size of the final fonts aren't the same... as you can see here.
Monaco patched.zip

PS/ I've updated the gist, just in case you wanted to take a look to the output.

[ryanoasis]

@luisspuerto Ah okay darn. Thanks for the details and screenshots! 😄

Hopefully we can figure out what's happening 😟

[luispuerto]

Thanks! I hope so, because I've would like to have Monaco font patched.
Have you tried to patch yourself?

I've also emailed @taohex asking about how exactly they did the patch, but they didn't reply me yet.

[luispuerto]

@ryanoasis by the way... can you try to patch yourself and see if the result is the same?

Thanks!

[luispuerto]

Hey!

Any progress? I just did the patch in a computer with a clean install or high sierra and I have the same problem. It's like the height of lines increased for some reason... Perhaps some of the glyphs aren't adapting to the height. Probably the powerline ones.

[ryanoasis]

@luisspuerto Hey no I haven't tried patching myself. Also sorry no progress on this issue. Mostly getting caught up with the backlog of PRs (now finally merged). Next up will be the v1.2.0 Release

[luispuerto]

don't worry... and let's see if with the new release the issue fixes itself. 😊

[glepnir]

@ryanoasis I don't think it solved. Is it reopened?Monaco has some problem, I got such a graph, the size of many graphics is not normal, specifically it is bigger。

i test e0b0 e0b1 e0b2 e0b3 e0b9 e0bf e0c0 e0c2 e0c1 e0c3 e0bb e0bd
e0cc e0c8 e0b6 e0b8 e0ba e0c6 e0b4 e0bc e0be ,
I found these characters, their performance is not normal, on the statusline, these graphics will exceed a part。

[luispuerto]

as far as I know it's not working... I usually tweak the result with font-forge app, but it's not perfect.

It's pretty clear that something it's going on and the result monaco+nerds fonts doesn't have the same height as Monaco.

[glepnir]

as far as I know it's not working... I usually tweak the result with font-forge app, but it's not perfect.

It's pretty clear that something it's going on and the result monaco+nerds fonts doesn't have the same height as Monaco.

@luispuerto yes,Unable to patch it, this issue should remain open until it is fixed

[glepnir]

@ryanoasis
I have noticed this problem for a long time, is it necessary to fix the monaco font?

[JoveYu]

any update? really need monaco patched font

[luispuerto]

I don't know if in the last version of the script whether this is fixed. I got mine patched and them I fixed it a little bit, so I was able to use it, but nothing more.

[JoveYu]

I use latest version to patch font, but not work ,the powerline symbols still too big, @luispuerto can you upload you patched monaco font?

[luispuerto]

@JoveYu I can't upload it, since Monaco has a private license. It's own by Apple as far as I know.

You can contact me and I can share with you, thought.

[JoveYu]

@luispuerto OK Thank you, please check your Inbox of email

[fragilelambda]

@JoveYu @luispuerto I met the same issue here, would you guys share that with me please? Thank you in advance!

[luispuerto]

@fragilelambda I no longer use that font since there was another issues. I'm using meslo that is really similar.

[luispuerto]

@ryanoasis I really don't know if I should close the issue. I no longer have it, since I'm no longer use the monaco patched font so I really don't know the issue it's still there or not.

I also find it really pointless to have an issue here that if it's still happening you aren't going to fix for whatever reason. If this is the case, just label it as wontfix and close it.

[ryanoasis]

Hey I know it's been a very long time. I just haven't had the time to catch up. I know we need a better system of at least triaging the issues so there is at least some organizing. I feel like something like this should still attempt to be fixed.

[qiuwei]

I can confirm that this issue still persists with Monetery.

[Finii]

Ok, lets see which target fonts we have here

• Monaco
• Menlo
• Monetery

And I see two issues mentioned:

• Too big / high powerline synbols
• icons too small / far down

This should be fixable ;-)

[Finii]

Hmm, with Menlo I can not reproduce (with current font-patcher).

The font does look ok:

This has been my Menlo source:

This is how I patched...:

Probably this has been fixed by #593.

Lets see if I can find the other fonts.

[Finii]

Monaco also looks good:

Source I used:

Patching process:

[Finii]

So maybe you just need to update your font-patcher script.

Some of the size problems have been tackled with #593. That should fix it for all 'well formed' font files, i.e. with font metrics set correctly. I could not imagine Apple giving wrong numbers in their font files.

I can not find any font called Monetery @qiuwei, please give more information on that font if you still have the problem with a current font-patcher.

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.