Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid escape sequence warnings when running font-patcher script #1643

Closed
3 tasks done
mearleycf opened this issue May 29, 2024 · 5 comments
Closed
3 tasks done

invalid escape sequence warnings when running font-patcher script #1643

mearleycf opened this issue May 29, 2024 · 5 comments

Comments

@mearleycf
Copy link

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

Experienced behavior:
I was performing a dry run of font-patcher to make sure it wouldn't return any errors, etc. When I run the following command, I get the following output:

❯ fontforge -script ~/Downloads/Nerd\ Fonts\ Patcher/font-patcher ~/patched_fonts/mononoki-nerd-fontv2/mononoki-Regular.otf --complete --dry --outputdir ~/patched_fonts/mononoki-nerd-font-v2/1.0.0/
Copyright (c) 2000-2023. See AUTHORS for Contributors.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
 Version: 20230101
 Based on sources from 2023-01-01 05:27 UTC-D.
/Users/mikeearley/Downloads/Nerd Fonts Patcher/font-patcher:432: SyntaxWarning: invalid escape sequence '\='
  message = "   Generated {} fonts\n   \===> '{}'".format(len(sourceFonts), outfile)
/Users/mikeearley/Downloads/Nerd Fonts Patcher/font-patcher:448: SyntaxWarning: invalid escape sequence '\='
  message = "   {}\n   \===> '{}'".format(sourceFont.fullname, outfile)
/Users/mikeearley/Downloads/Nerd Fonts Patcher/font-patcher:2028: SyntaxWarning: invalid escape sequence '\.'
  if re.match("\.ttc$", args.extension, re.IGNORECASE):
Nerd Fonts Patcher v3.2.1 (4.13.1) (ff 20230101)
INFO: Setting Panose 'Family Kind' to 'Latin Text and Display' (was 'Any')
INFO: Setting Panose 'Proportion' to 'Monospaced' (was 'Any')
Done with Patch Sets, generating font...

Expected behavior:
As a test, I corrected those 3 issues, and they didn't print when I ran the --dry run again. Maybe the font-patcher script needs some minor updates?

Example symbols:
n/a

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    mononoki (the original one--not the old archived patched one)
  • Where did you get the file from (download link, self patched, source downloaded from link...)
    pretty sure I got it here: https://github.com/madmalik/mononoki
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
    kitty
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    OS X Sonoma
@Finii
Copy link
Collaborator

Finii commented May 29, 2024

Thanks for being observative and taking the time to report the issue 💚

This has already been fixed via cb0c9ed in in-parens-version 4.14.3 (you use 4.13.1).

@Finii Finii closed this as completed May 29, 2024
@D3vil0p3r
Copy link

Thanks for being observative and taking the time to report the issue 💚

This has already been fixed via cb0c9ed in in-parens-version 4.14.3 (you use 4.13.1).

I am getting the same issue when I use the latest stable 3.2.1 release. If the issue has been fixed in the git repo, could you please release a new stable release with this fix?

@jdanbrown
Copy link

+1 I just tripped over this too. @Finii Mind cutting a release for v3.3.0?

My workaround is to manually clone the repo instead to get the commit you linked above (cb0c9ed). Unfortunately this takes much longer than it took to download the FontPatcher.zip (2.3mb) from the v3.2.1 release — looks like my shallow git clone needs to download ~1.2gb of data from github.

$ git clone --depth 1 --branch v3.3.0 [email protected]:ryanoasis/nerd-fonts.git

@Finii
Copy link
Collaborator

Finii commented Nov 18, 2024

My workaround is to manually clone the repo instead

Hmm, how do you get the 'old' patcher script?
Cloning the repo is not recommended, use the FontPatcher.zip or the Docker image.

The FontPatcher.zip contains all stuff you need, except fontforge itself.
There is the release one on the release page, but also a HEAD one in-repo that you can use.

The Docker is also on HEAD.

Mind cutting a release for v3.3.0?

See https://github.com/ryanoasis/nerd-fonts/releases/tag/untagged-b0629bf76518b7c278c1
and

@jdanbrown
Copy link

👍 Thanks, I see the v3.3.0 release now:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants