-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Lucide Icons #1389
Comments
Following comments I moved here (manually): |
Originally posted by @danielbayley in #1095 (comment) @Finii Suggesting Lucide icons, instead of Feather icons, as mentioned in #665. Lucide is a much better fork of Feather… Ah, thanks for the hint. Unfortunately they seem to be web- and single-icon-use-centric, as they do not keep codepoints constant. I just opened up two versions 1/2 year apart or so, and in the new version they stuffed in more icons in between existing ones: It is of course bad to change the codepoints, as terminal users address the icons solely by codepoints, and they rightfully expect their beautiful shell prompt to stay the same (icon wise) on updates. They seem to have not understood that codepoint stability is important for the font files. (It does not matter for usage via name, as typical web users do). Of course we could - manually and laboriously - introduce some mechanism to add the codepoint guarantee, but with >1000 icons that would really be a maintenance burden. 🤔 And WHY do they add one arrow with filled head (green) and the other directions with open head (blue)? 😒 To make sure you understand what I mean (and because you seem to be involved with Lucide) Assume we have a user that wants a fruit in the prompt. People tend to like their OS-icons in the prompt (for reasons that are beyond me, but that does not matter). This person installs a Nerd Font, finds that the fruit has codepoint This is nothing Nerd Font can/want to follow. I assume Lucida takes all currently available
Maybe you want to bring that problem up at Lucide. For me ... those icon sets grew me grey hairs... Addendum: #365 (comment) says (see 'update codepoint stable' column): For the octicons we re-establish codepoint stability with some scripts: https://github.com/ryanoasis/nerd-fonts/tree/master/src/glyphs/octicons
|
Originally posted by @danielbayley in #1095 (comment)
@Finii Yes I added many of those icons myself 😅 But had no control over the associated codepoints… Which I agree should be kept stable. I already understand the issue since running into it myself, with my vscode-lucide-icons extension (almost ready!) as VSCode also operates on font codepoints for icons… I dealt with it there by writing a script based on matching up names, using the opentype package, to find the correct unicodes after a font update (sounds similar to how you mention addressing the problem with octicons) But this is not really the proper longterm solution…
Comparing the latest font with an old version will have different codepoints (as many new icons), but just recently I think the underlying issue should have been fixed in lucide-icons#1413, so this should hopefully not be a problem going forward… @Finii See relevant issue/PRs: lucide-icons#514, lucide-icons#1413 and lucide-icons#1599.
Not sure exactly what happened there, obviously they weren’t designed that way… It might have something to do with the source SVGs not being outlined properly before the font gets generated (all Lucide icons are purely stroke based). I think this should also be fixed by the updated build process, implemented in lucide-icons#1413, as mentioned. cc: @ ericfennis @ schmidt-oliver @ karsa-mistmere |
Originally posted by @schmidt-oliver in #1095 (comment)
The underlying problem should be fixed after pull request #1599 is merged. However, I can't promise that it won't cause problems when icons are renamed or deleted. |
After looking into the PR I think this is how they did it:
Which of course breaks all codepoints if a rather old icon is ever dropped. There is not even a real way to fill the then-vacant codepint with a new icon to avoid shifting, except by lying about the Unfortunately there has been a nice and clean solution (with a dedicated table), but that has been removed from the relevant PR: With this comment: lucide-icons/lucide#1413 (comment) That is really a pity and I do not understand the problem with fetching the file (i.e. |
Yeah I think this algorithm needs to be rethought, with a focus on stable codepoints, taking into account the possibility of old icons being removed/renamed… and also @Finii Might be worth opening a new issue there, for better visibility… |
Closing because transferred to #1095 |
See also |
There is an Issue for adding the Feather icons:
The Lucide icons are a fork of Feather, with a very active contributor scene:
https://github.com/lucide-icons/lucide
There were already some discussions ongoing, let put them here in their own topic.
The text was updated successfully, but these errors were encountered: