Replies: 3 comments
-
Appendix with relevant code snippet in self.sourceFont.generate(self.args.outputdir + "/" + self.sourceFont.fullname + self.extension, flags=(str('opentype'), str('PfEd-comments')))
print("\nGenerated: {}".format(self.sourceFont.fontname)) ( We generate with |
Beta Was this translation helpful? Give feedback.
-
Issue mentioned by @nobuyukinyuu in #632; this change would solve illegal file names. Which characters are allowed in filenames? Postscript names allow
There is nothing in Edit: Completely reversed the content of this comment :-D |
Beta Was this translation helpful? Give feedback.
-
At the moment all the font filenames contain blanks, i.e.
Inconsolata Regular Nerd Font Complete Mono Windows Compatible.otf
.Usually font files do not have blanks in them.
Lets see (at root of repo):
This means only less then 10% (58) of all source fonts contain blanks, 690 do not.
And what we produce, ignoring the 4 variants for each font:
I would change that so the filename is (like usual) the Postscriptname and not the Human-readable-name (Fullname).
That would also exclude problematic characters from the filename.
The impact might be rather big, as renaming is always an issue, but these blank-embedded-filenames bugger me since ancient times ;)
Beta Was this translation helpful? Give feedback.
All reactions