-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Lock Exoplayer Response Code 500 / Proxy Status Error: 400 #832
Comments
@ryanheise After reading through #594 im not 100% if it is duplicate because #594 is really hard to follow. I try my best to understand it, at the moment i think it could be another impact of the bug. I'm not 100% sure because on #594 it looks like the proxy is dying at some point, but for my error it seem to never work. |
I have just tested regular just_audio without the background (since that's more minimal and helps narrow it down), and it also does reproduce the issue. |
I've committed a fix to the |
Hallo @ryanheise ! I can confirm that headers are now working in the fix branch. Great work, thank you. 🦄🌈 |
Thanks for confirming that. P.S. Nice edit on your comment ;-) |
Note that I will need to do some further refactoring before I release this. I will let you know once that's done in case I break things again. |
Sounds good! I use the fix branch in a MVP which is fine for me, would be nice if you can keep it running until you release the fix. |
I've just done the refactoring. This may or may not break things. Would you like to test? |
The refactored version has now been merged and published. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs, or use StackOverflow if you need help with just_audio. |
Thanks for your great libraries 🧡 . I found an issue with the experimental LockCachingAudioSource in combination with background audio and headers. I tried my best to fulfil the Bug Report requirements :)
Which API doesn't behave as documented, and how does it misbehave?
LockCachingAudioSource does not work in combination with headers set, at least if you use Just_audio_background (didnt try without background use)
If you don't set headers everything works fine.
Minimal reproduction project
https://github.com/matecode/just_audio/tree/LockCachingAudioSource-Header-Issue
To Reproduce (i.e. user steps, not code)
Error messages
Expected behavior
The headers should be used for the request and there should be no error if using headers.
Smartphone (please complete the following information):
Tested on
Flutter SDK version
The text was updated successfully, but these errors were encountered: