Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

fix your CI #2

Open
theofficialgman opened this issue Jan 8, 2023 · 2 comments
Open

fix your CI #2

theofficialgman opened this issue Jan 8, 2023 · 2 comments

Comments

@theofficialgman
Copy link

theofficialgman commented Jan 8, 2023

I have noticed this on many of your repos. instead of using builtin electron-buider features. you create a zip, download an old deb, and then manually repackage it.

electron-buillder can be used directly to make the deb with everything necessary (.desktop file, control, etc)

npx electron-builder --linux deb --armv7l --publish never

electron-builder can natively produce deb, rpm, zips, and appimages for linux

the CI becomes very simple:

npm install
npx electron-builder --linux deb --armv7l --publish never
# npx electron-builder --linux deb --arm64 --publish never

and then publish the deb from the dist folder (rename it if you need to)

edit: removed some harsh wording

@ryanfortner
Copy link
Owner

Sorry it took awhile to get around to this. The method of manually repackaging was introduced to me in #1, I guess I never paid much attention to it. Your method is much more efficient so I'll switch in a minute, thanks!

@theofficialgman
Copy link
Author

repo can be archived once JannisX11/blockbench#2187 merges and a new release is made

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@theofficialgman @ryanfortner and others