-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Runner class to monitor and activate ember apps #145
Conversation
Does it work for you? Any feedback from your projects @rondale-sc? |
@rwz this worked great for me! |
c.app :frontend, path: "/path/to/your/ember-cli-app/on/disk" | ||
c.app :frontend, | ||
path: "/path/to/your/ember-cli-app/on/disk", | ||
enable: -> path { path.starts_with?("/app/") } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwz I've covered the positive use case, would it make sense also covering a negative case:
!path.starts_with?("/api/")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's automatically implied. Anyone who sees a lambda passed in as an option should figure out it could be used for negative case by just inverting the logic.
@rwz @seanpdoyle Works on our production app without any changes! LGTM 🍻 (kinda obvi, but it doesn't restart ember until the next request) |
Add Runner class to monitor and activate ember apps
Released 0.3.0 |
How does this enable option work? I have this config for EmberCLI
And I have these routes:
When I open http://localhost:3000/api/v1/users it goes to Ember and it complains that
|
@slashmili I believe the |
Correct! Thanks BTW it was not obvious though. |
@slashmili I agree. However, |
@seanpdoyle I'm not super familiar with asset pipeline internals. We have some assets that are still managed by rails - (fonts, images, etc). Would it step on the ember-cli-rails middleware to also flip enabled to false on cases of |
Should address #107 and #139