Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby support #20

Closed
nadavshatz opened this issue Dec 10, 2014 · 12 comments
Closed

JRuby support #20

nadavshatz opened this issue Dec 10, 2014 · 12 comments

Comments

@nadavshatz
Copy link

Hey there, I get Ruby ~> 2.0 needed. Is there a reason not to support JRuby?

Cheers for this!

@rwz
Copy link
Collaborator

rwz commented Dec 10, 2014

Doesn't JRuby support 2.0 syntax?

@nadavshatz
Copy link
Author

No, it's still at 1.9.3 compatibility.

@rwz
Copy link
Collaborator

rwz commented Dec 10, 2014

http://stackoverflow.com/questions/15281036/how-to-run-ruby-2-0-with-jruby-1-7

It says there is a 2.0 compat mode in JRuby.

Also, there might be a way to make the whole gem fully 1.9.3 compat. We'd need to get rid of Module#prepend call and replace it with some sort or alias_method_chain-like hack.

@nadavshatz
Copy link
Author

http://jruby.org/

You can see they mention only 1.9.3 and 1.8. I guess it's not fully/officially supported. This gem might actually work but because of the gemspec i think it won't even install.

I'm getting this with jruby-1.7.16

Gem::InstallError: ember-cli-rails requires Ruby version ~> 2.0.
An error occurred while installing ember-cli-rails (0.0.5), and Bundler cannot
continue.
Make sure that `gem install ember-cli-rails -v '0.0.5'` succeeds before
bundling.

@rwz
Copy link
Collaborator

rwz commented Dec 10, 2014

Have you tried running gem install in 2.0 compat mode?

@nadavshatz
Copy link
Author

I can't as my gemfile defines the ruby version as 1.9.3 on purpose to make sure all gems installed function properly.

@rwz
Copy link
Collaborator

rwz commented Dec 10, 2014

:(

Well, we'll probably fix that soon. There's almost nothing that makes this gem impossible to work on 1.9.3.

@nadavshatz
Copy link
Author

If you want I can give it a go and send a pull request.

@rwz
Copy link
Collaborator

rwz commented Dec 10, 2014

I plan to push a big chunk of changes pretty soon because of the other issues we have, it'll probably make your pull-request irrelevant due to conflicts.

@nadavshatz
Copy link
Author

gotya well, looking forward =]

@rwz rwz closed this as completed in 2f304ec Dec 10, 2014
@rwz
Copy link
Collaborator

rwz commented Dec 10, 2014

Just released a new version that's fully 1.9.3 compatible. Please give it a try.

@nadavshatz
Copy link
Author

Thanks! looks good so far :)

seanpdoyle added a commit that referenced this issue Nov 14, 2015
Always pass `--environment test` to `ember test` command from Rails.

Resolve testing issue by adding test coverage.

Required [rondale-sc/ember-cli-rails-addon#20] to correct fingerprinting
issue.

[#20]: rondale-sc/ember-cli-rails-addon#20
seanpdoyle added a commit that referenced this issue Nov 14, 2015
Always pass `--environment test` to `ember test` command from Rails.

Resolve testing issue by adding test coverage.

Required [rondale-sc/ember-cli-rails-addon#20] to correct fingerprinting
issue.

[#20]: rondale-sc/ember-cli-rails-addon#20
seanpdoyle added a commit that referenced this issue Nov 14, 2015
Always pass `--environment test` to `ember test` command from Rails.

Resolve testing issue by adding test coverage.

Required [rondale-sc/ember-cli-rails-addon#20][#20] to correct
fingerprinting issue.

[#20]: rondale-sc/ember-cli-rails-addon#20
seanpdoyle added a commit that referenced this issue Nov 14, 2015
Always pass `--environment test` to `ember test` command from Rails.

Resolve testing issue by adding test coverage.

Required [rondale-sc/ember-cli-rails-addon#20][#20] to correct
fingerprinting issue.

[#20]: rondale-sc/ember-cli-rails-addon#20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants