Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement standard Conformer encoder #54

Closed
albertz opened this issue Nov 3, 2021 · 3 comments · Fixed by #58
Closed

Implement standard Conformer encoder #54

albertz opened this issue Nov 3, 2021 · 3 comments · Fixed by #58
Assignees
@mmz33 @tbscode
Milestone
first-release

Comments

@albertz
Copy link
Member

albertz commented Nov 3, 2021

Similar as Transformer in #53.
Using self-attention from #52.
Maybe making other sensible building blocks as needed.
@albertz albertz added this to the first-release milestone Nov 3, 2021
@albertz albertz mentioned this issue Nov 3, 2021
Open
@mmz33 mmz33 mentioned this issue Nov 4, 2021
Merged
@albertz albertz reopened this Nov 9, 2021
@albertz
Copy link
Member Author

albertz commented Nov 9, 2021

Reopen before this is not really tested.

@albertz albertz mentioned this issue Nov 10, 2021
Open
@albertz

This comment was marked as resolved.

Sign in to view
@albertz
Copy link
Member Author

albertz commented Mar 8, 2022

So we have a test case now, and looks all good.

@albertz albertz closed this as completed Mar 8, 2022
@albertz albertz mentioned this issue Nov 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmz33 mmz33

@tbscode tbscode

Labels
None yet
Projects
None yet
Milestone
first-release
Development

Successfully merging a pull request may close this issue.

Conformer Modules rwth-i6/returnn_common
3 participants
@albertz @mmz33 @tbscode