Insert new changelog content before the first h2 existing element #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version headings in lerna-changelog are h2, not h3
... or at the start of the file if none is found
|
This should fix https://github.com/rwjblue/create-rwjblue-release-it-setup/blob/d7b0d4faeb50392a0ef251332797197cb89498ec/__tests__/bin-test.js#L61-L67 then right (by making it not something we want to do, but instead we'd do the opposite and add one)? |
rwjblue
approved these changes
Oct 29, 2020
| @@ -147,7 +147,7 @@ test('it uses the first commit when no tags exist', async (t) => { | |||
| value: 'hahahahaah, does not exist', | |||
| }, | |||
| 'git rev-list --max-parents=0 HEAD': 'aabc', | |||
| [`${LERNA_PATH} --next-version=Unreleased --from=aabc`]: `### Unreleased\n\nThe changelog\n### v1.0.0\n\nThe old changelog`, | |||
There was a problem hiding this comment.
ugg didn't realize I had this different than what lerna-changelog did itself 😩
I guess, yeah. I hadn't actually seen that test yet 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... or at the start of the file if none is found
Resolves #90