Fix transform to not touch native <input> #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ember-polyfills#78 That was a pretty stupid one: the transform would treat `<input />` the same as `<Input />`, i.e. transform it to `{{input}}`. 🤦♂️ Fixed that, added a test, and also tested it with the test suite of ember-bootstrap, which uncovered this issue as reported in ember-polyfills#78. Had to extract some of the existing helpers that work around the issue of earlier Ember version's AST returning the lower-cased tag name, tu reuse them here.
simonihmig
commented
Aug 2, 2019
| @@ -104,15 +108,15 @@ class AngleBracketInputPolyfill { | |||
|
|
|||
| let visitor = { | |||
| ElementNode(node) { | |||
| let tag = node.tag.toLowerCase(); | |||
There was a problem hiding this comment.
That's the culprit, which I copy pasted blindly from the link-to transform, which does not work here obviously 🙈
Sorry about that!
rwjblue
approved these changes
Aug 2, 2019
|
Thanks for digging into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
That was a pretty stupid one: the transform would treat
<input />the same as<Input />, i.e. transform it to{{input}}. 🤦♂️Fixed that, added a test, and also tested it with the test suite of ember-bootstrap, which uncovered this issue as reported in #78.
Had to extract some of the existing helpers that work around the issue of earlier Ember version's AST returning the lower-cased tag name, to reuse them here.