Add polyfill for angle brackets <LinkTo> #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonihmig
commented
Jul 12, 2019
simonihmig
force-pushed
the
builtin-components
branch
3 times, most recently
from
89eff29
to
f596042
Compare
simonihmig
changed the title
|
This now includes #73, which should be merged first, and I'll rebase this afterwards. Other than that this should be ready for review! |
rwjblue
reviewed
Jul 14, 2019
|
Ok, the other two PR’s are landed. I think CI should be good to go with a rebase... |
simonihmig
force-pushed
the
builtin-components
branch
from
f596042
to
074a8ab
Compare
simonihmig
commented
Jul 14, 2019
|
|
||
| let route = attributes.find(({ name }) => name === '@route'); | ||
| let model = attributes.find(({ name }) => name === '@model'); | ||
| let models = attributes.find(({ name }) => name === '@models'); |
There was a problem hiding this comment.
We should probably put an assertion here that either model or models is passed, but not both, right? (as specified in the RFC)
Anything else we should cover? (an empty route is valid?)
There was a problem hiding this comment.
Ya, empty route is fine. Assertion for both model and models is good.
Partially implements ember-polyfills#66
simonihmig
force-pushed
the
builtin-components
branch
from
074a8ab
to
6b473b3
Compare
|
Rebased and green now! 🎉 |
|
Thanks for working on this!! Traveling atm but will try to get a release for these out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #66. A follow-up PR for
<Input>should be pretty straightforward...