Fix class merging and attribute precedence #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #25.
In addition to special-casing the "class" attribute, this also fixes attribute precedence when an attribute is placed before vs after
...attributes.I eliminated the use of references whose value contains more references. I found it hard to reason about when composing across arbitrarily many levels. Now all the references represent true usermode values, and we use PathReference
getfor peeling individual references off of hashes.Edit to add: forgot to mention, but now this polyfill is "more correct" than Ember until emberjs/ember.js#17533 is fixed.