Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using the quote_ macros #678

Closed
SergioBenitez opened this issue Jun 26, 2018 · 3 comments
Closed

Stop using the quote_ macros #678

SergioBenitez opened this issue Jun 26, 2018 · 3 comments
Labels
nightly breakage Breakage on the nightly channel only

Comments

@SergioBenitez
Copy link
Member

An issue/PR removing the quote_ macros from rustc is underway (rust-lang/rust#51285, rust-lang/rust#46849). Rocket uses quite a few of these macros in a fairly fundamental way, so this is a fairly large breaking change for Rocket. A workaround is needed.
@SergioBenitez SergioBenitez added the nightly breakage Breakage on the nightly channel only label Jun 26, 2018
@eddyb
Copy link

eddyb commented Jun 26, 2018

Ideally a full transition to proc_macro + syn + quote should be done, to avoid further trouble when the existing plugin API will be removed.

@SergioBenitez
Copy link
Member Author

That's the hope, @eddyb, but it's a serious undertaking that I was hoping to postpone for another month.

@SergioBenitez
Copy link
Member Author

Let's track this in #693.

@jebrosen jebrosen mentioned this issue Jul 10, 2018
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nightly breakage Breakage on the nightly channel only
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eddyb @SergioBenitez