Add spark fun gps #1074
Add spark fun gps #1074
Conversation
… logic since the board is a bit finicky.
|
I'm not sure what's up with the serialport test failing. Is there anything I need to do to fix that? |
|
No, it's some strange thing that appeared recently :( |
lib/gps.js
Outdated
| * SkyTraq Binary Message Protocol | ||
| * http://cdn.sparkfun.com/datasheets/Sensors/GPS/Venus/638/doc/AN0003_v1.4.19.pdf | ||
| */ | ||
| GPS.prototype.sendSkyTraqCommand = function(payload, callback) { |
There was a problem hiding this comment.
Is this specific to just this model? There shouldn't be component specific methods like this, so I think you and @dtex should coordinate on this implementation.
rwaldron
force-pushed
the
master
branch
4 times, most recently
from
7e94449 to
aaee114
Compare
|
It looks like the heavy lifting is done, just some refactoring. How do you (@rwaldron) feel about that proposed PARSER object? |
|
@dtex but there is still both a |
|
Also, needs one of these: |
|
sendCommand will vary with the chip but parsers will not so just leave sendCommand on the prototype and override that with a custom sendCommand on CHIP.VENUS638FLPX. |
Yeah, this is what I wanted. I don't want another sort-of-like-sendCommand-thing. |
|
I can work on those changes. I've got a pretty good idea of what needs to happen. Is the best way to get this in is to fork makenai:addSparkFunGPS and make a PR to that, or should I just open a new PR here? |
That's what I would recommend doing :) it will be trivial for @makenai to land it when you're ready |
Also make sure that chip specific commands overwrite the same commands not he prototype.
… logic since the board is a bit finicky.
Also make sure that chip specific commands overwrite the same commands not he prototype.
Add PARSERS object
rwaldron
force-pushed
the
master
branch
5 times, most recently
from
beb9597 to
4357638
Compare
|
Hi @makenai, Are you back home? NBD is behind us and I wanted to get Tessel GPS support added but we should land this first. Any plans to work on it soon? If not, I could probably get my hands on a Venus and apply the finishing touches. Your trip looked awesome BTW. I so want to visit there. |
|
Yup, I'm back! And this has been weighing heavily on my conscience. :) I'm at CascadiaFest this week, but I'm going to plan to take a look at it during / possibly a bit after depending on my motivation level. |
|
Okay, have fun at Cascadia. I was there last year and had a really good time. |
rwaldron
force-pushed
the
master
branch
2 times, most recently
from
7d6e95a to
935fd36
Compare
|
🔔 |
|
@makenai I'm anxious to land support for the Tessel GPS module. I want this ball of cups to be able to drive itself around the block (Halloween is coming and how fun would it be to add some lights and let it go?). I've been holding off because I refactored a lot in my PR to your repo and I don't want to lose that. Also, I'm worried that if I submit my own PR with the Tessel GPS stuff it will make merging a ginormous PIA for you. Do you think you'll have it in the next couple of weeks? |
|
Hi @makenai, I hope all is well. This PR has sat for a while and neither one of us have gotten around to it. I want to close it for cleanliness but I don't want the addition of the Venus to fall off the radar. To handle cases like this I've created a new Requested Features page in the wiki and added it to that list. |
This adds support for the SparkFun Venus GPS module: https://www.sparkfun.com/products/11058