Skip to content

Commit

Permalink
fix: reset script from package.json does not work hyperledger-cacti#1656
Browse files Browse the repository at this point in the history


fixes: hyperledger-cacti#1656

Upon reading further about yarn.lock, del-cli yarn.lock wasn't needed and may cause problems. Letting yarn update the yarn.lock file is the better way in terms of updating dependencies.
(https://classic.yarnpkg.com/en/docs/yarn-lock/#toc-managed-by yarn : # Managed by Yarn)
(https://stackoverflow.com/questions/60509429/is-it-a-good-idea-to-delete-yarn-lock-and-generate-it-again-by-running-yarn-inst)
(https://stackoverflow.com/questions/41126217/how-to-sync-yarn-lock-with-package-json)

Testing has also been done in terms of using "del-cli '**/node_modules'" and reinstalling it.
yarn del-cli emptied node_modules.
yarn install --update-checksum --force checks yarn.lock and updates it necessarily and also installs node_modules together.
yarn configure configured the package and outputs all lerna success.
yarn reset is also reusable even after using yarn reset once unlike the other solutions implemented.

Signed-off-by: ruzell22 <[email protected]>
  • Loading branch information
ruzell22 committed Feb 22, 2022
1 parent 8d7ab85 commit c260ff1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"run-ci": "./tools/ci.sh",
"reset:node-modules": "del-cli '**/node_modules'",
"reset:git": "git clean -f -X",
"reset:yarn-lock": "del-cli yarn.lock && yarn install --update-checksums --force",
"reset:yarn-lock": "yarn install --update-checksums --force",
"reset": "run-s reset:git reset:node-modules reset:yarn-lock configure",
"configure": "yarn install --frozen-lockfile --non-interactive && yarn run build:dev:backend",
"install-yarn": "npm install --global [email protected]",
Expand Down

0 comments on commit c260ff1

Please sign in to comment.