Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use win32 chromedriver binary on win64, update chromedriver version and fix error message #537

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Use win32 chromedriver binary on win64, update chromedriver version and fix error message #537

merged 2 commits into from
Feb 5, 2019

Conversation

jscheffner
Copy link
Contributor

This solves #535.

Changes:

  • use win32 chromedriver binary on win64 systems
  • update chromedriver version to 2.45
  • fix error message

@jscheffner
Copy link
Contributor Author

@ashleygwilliams: I updated the chromedriver version to 2.45 because you said so, but there is already a version 2.46. Is there any reason not to use this? Also, should I also update the geckodriver version to the latest?

@ashleygwilliams ashleygwilliams modified the milestones: 0.7.0, 0.6.1 Feb 5, 2019
@ashleygwilliams
Copy link
Member

@jscheffner sorry about that! the most up to date is all i meant!

ashleygwilliams
ashleygwilliams approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ashleygwilliams ashleygwilliams merged commit 02ce286 into rustwasm:master Feb 5, 2019
@jscheffner jscheffner deleted the chromedriver-binaries-unavailable branch February 8, 2019 17:37
@fitzgen fitzgen added the TWiRaWA Nominate this PR for inclusion in the next issue of This Week in Rust and WebAssembly label Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees
No one assigned
Labels
changelog - fix needs review TWiRaWA Nominate this PR for inclusion in the next issue of This Week in Rust and WebAssembly
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jscheffner @ashleygwilliams @fitzgen