-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm-pack build should copy over the license file #407
Labels
Milestone
Comments
oh dang, good catch! do you think it would be reasonable enough to copy over whatever the LICENSE key in Cargo.toml points to? that'd be my first impl strategy... |
ashleygwilliams
added
bug
Something isn't working
to-do
stuff that needs to happen, so plz do it k thx
labels
Oct 12, 2018
Ah, yes—I think that'd be entirely adequate.
|
ashleygwilliams
added
help wanted
Extra attention is needed
good first issue
Good for newcomers
hacktoberfest
labels
Oct 12, 2018
If no one has jumped on this one yet I'd like to take a crack at implementing this! |
you got it @mstallmo - go for it! thanks so much! |
ashleygwilliams
removed
good first issue
Good for newcomers
help wanted
Extra attention is needed
labels
Oct 12, 2018
3 tasks
ashleygwilliams
added
changelog - fix
and removed
PR attached
there's a PR open for this issue
bug
Something isn't working
hacktoberfest
to-do
stuff that needs to happen, so plz do it k thx
labels
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, license files aren't copied over. It's not entirely clear to me how best to do this, given that license files can have different names. Perhaps do (the equivalent of)
cp LICENSE* pkg
?The text was updated successfully, but these errors were encountered: