Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-pack build should copy over the license file #407

Closed
tschneidereit opened this issue Oct 12, 2018 · 4 comments · Fixed by #411
Closed

wasm-pack build should copy over the license file #407

tschneidereit opened this issue Oct 12, 2018 · 4 comments · Fixed by #411
Milestone

Comments

@tschneidereit
Copy link

Currently, license files aren't copied over. It's not entirely clear to me how best to do this, given that license files can have different names. Perhaps do (the equivalent of) cp LICENSE* pkg?

@ashleygwilliams
Copy link
Member

oh dang, good catch! do you think it would be reasonable enough to copy over whatever the LICENSE key in Cargo.toml points to? that'd be my first impl strategy...

@ashleygwilliams ashleygwilliams added bug Something isn't working to-do stuff that needs to happen, so plz do it k thx labels Oct 12, 2018
@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Oct 12, 2018
@tschneidereit
Copy link
Author

tschneidereit commented Oct 12, 2018 via email

@ashleygwilliams ashleygwilliams added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 12, 2018
@mstallmo
Copy link
Member

If no one has jumped on this one yet I'd like to take a crack at implementing this!

@ashleygwilliams
Copy link
Member

you got it @mstallmo - go for it! thanks so much!

@ashleygwilliams ashleygwilliams removed good first issue Good for newcomers help wanted Extra attention is needed labels Oct 12, 2018
@ashleygwilliams ashleygwilliams added the PR attached there's a PR open for this issue label Oct 14, 2018
@ashleygwilliams ashleygwilliams added changelog - fix and removed PR attached there's a PR open for this issue bug Something isn't working hacktoberfest to-do stuff that needs to happen, so plz do it k thx labels Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants