Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect if cargo toml has wasm-bindgen dep #141

Closed
ashleygwilliams opened this issue Jun 5, 2018 · 4 comments
Closed

detect if cargo toml has wasm-bindgen dep #141

ashleygwilliams opened this issue Jun 5, 2018 · 4 comments
Labels
good first issue Good for newcomers PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Milestone

Comments

@ashleygwilliams
Copy link
Member

this issue is reserved for someone who has not yet contributed to wasm-pack


in order to compile to wasm32-unknown-unknown, the user must put the following in their Cargo.toml:

[dependencies]
wasm-bindgen = "0.2"

we have the ability to check this before we try to compile- to save the user some time and help remind them to do it!

we'll probably want to work on this in the manifest.rs file, and it might be similar to the get_crate_name function... see here

@ashleygwilliams ashleygwilliams added help wanted Extra attention is needed good first issue Good for newcomers to-do stuff that needs to happen, so plz do it k thx labels Jun 5, 2018
@ashleygwilliams ashleygwilliams added this to the 0.4.0 milestone Jun 5, 2018
@robertohuertasm
Copy link
Contributor

robertohuertasm commented Jun 5, 2018

I'd love to tackle this one if it's ok for you!

@ashleygwilliams
Copy link
Member Author

@robertohuertasm you got it! let me know if you want any help!

@robertohuertasm
Copy link
Contributor

Do I have to check the version? If that's the case, must "0.2" be the minimum version or it has to be fixed?

@ashleygwilliams
Copy link
Member Author

@robertohuertasm i think for the moment we should just check that the dependency is present. the version portion is a bit more complicated and something we'll deal with when we resolve #146

@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue and removed help wanted Extra attention is needed labels Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Development

No branches or pull requests

2 participants