Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webidl variadic (...) support to web-sys #503

Closed
richard-uk1 opened this issue Jul 18, 2018 · 2 comments
Closed

Add webidl variadic (...) support to web-sys #503

richard-uk1 opened this issue Jul 18, 2018 · 2 comments
Labels
frontend:webidl Issues related to the WebIDL frontend to wasm-bindgen help wanted We could use some help fixing this issue!

Comments

@richard-uk1
Copy link
Contributor

richard-uk1 commented Jul 18, 2018 •
edited
Loading

Like optional this requires deciding how to represent this in rust. It could be a slice (so ...any becomes &[JsValue], etc.), or a varargs function. Since varargs isn't implemented yet (tracking issue), probably best to go with a slice.

Example of a variadic function in WebIDL (Console API):

[UseCounter]
void log(any... data);
@alexcrichton
Copy link
Contributor

Going with a slice now seems reasonable to me!

@fitzgen fitzgen added help wanted We could use some help fixing this issue! frontend:webidl Issues related to the WebIDL frontend to wasm-bindgen labels Jul 18, 2018
This was referenced Aug 13, 2018
Closed
Closed
@migerh migerh mentioned this issue Sep 1, 2018
Closed
2 tasks
@richard-uk1 richard-uk1 mentioned this issue Sep 1, 2018
Merged
@fitzgen
Copy link
Member

fitzgen commented Sep 5, 2018

Fixed in #726

@fitzgen fitzgen closed this as completed Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend:webidl Issues related to the WebIDL frontend to wasm-bindgen help wanted We could use some help fixing this issue!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @fitzgen @richard-uk1