Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise docs for gloo_net::http::Request.method #211

Closed
hseeberger opened this issue Apr 16, 2022 · 1 comment
Closed

Revise docs for gloo_net::http::Request.method #211

hseeberger opened this issue Apr 16, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@hseeberger
Copy link
Contributor

Currently the dosc state "Note that the Origin header is not set on Fetch requests with a method of HEAD or GET.". This is not correct, though, because according to the Fetch specification the Origin header is used for all methods that have a "CORS" response tainting.

For more context, see discussion 209.
@hseeberger hseeberger added the bug Something isn't working label Apr 16, 2022
@hseeberger hseeberger mentioned this issue Apr 16, 2022
Merged
@ranile
Copy link
Collaborator

ranile commented Apr 16, 2022

Fixed in #212

@ranile ranile closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hseeberger @ranile