-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std threads support #46
Conversation
Yay! Deleting code is nice.
Were you trying to
I think there's something to this stemming from the fact that |
This is probably the reason. Edit: most of the errors are gone, but there's a few more left (will investigate - probably just need stubs):
|
@AzureMarker make sure your deps are up-to-date – I recall seeing the same link errors I think until I did a |
@ian-h-chamberlain I tried the test command again after updating everything and it works! I also don't see any panic messages in the console (thanks to std threads). Some odd happens though if I run it a bunch of times. When exiting the 5th run, I get an ARM exception: prefetch abort (kernel panic). I haven't debugged this at all (just reproduced it), so it might be related to the std threads, or it's always been there, but that was weird. Edit: this happens on other examples as well. Interestingly, the "Fault status" is "Debug event" and it's an exception on core 1 (sys core, though that makes sense since the error says kernel panic). Edit 2: I noticed in Luma3DS's process list that there's zombie 3dsx_app processes when you open/close a program a few times. It panics when there are 4 zombies and you close the 5th 3dsx_app process. Edit 3: I opened a new issue for this: #48 |
This lets us delete the ctru-rs thread module.
The thread list syscall has a bug which causes the process to become a zombie. See #48.
# Conflicts: # ctru-rs/src/services/ps.rs
@Meziu @ian-h-chamberlain
Closes #45
Requires:
Feels good to delete a bunch of code.
I tried using
cargo 3ds test
with these changes though and got some weird linker errors. It looks like libctru is included twice, but pthread-3ds isn't at all? I'll try debugging more but let me know if you see issues.Edit: The test issues are fixed now.