Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link to sys_read_entropy #373

Closed
WhyNotHugo opened this issue Oct 3, 2023 · 4 comments · Fixed by #374
Closed

Broken link to sys_read_entropy #373

WhyNotHugo opened this issue Oct 3, 2023 · 4 comments · Fixed by #374

Comments

@WhyNotHugo
Copy link
Contributor

There's a broken link in the docs:

//! [`sys_read_entropy`]: https://hermitcore.github.io/libhermit-rs/hermit/fn.sys_read_entropy.html

I was going to send a PR instead of a patch, but it looks like this documentation is gone and not available online elsewhere.

Looking around I get an impression that it's been deprecated entirely? E.g.: https://github.com/hermitcore/, https://github.com/hermit-os/libhermit#deprecation-notice

@josephlr
Copy link
Member

josephlr commented Oct 4, 2023

Seems like the right doc is https://docs.rs/hermit-abi/0.3.3/hermit_abi/fn.read_entropy.html

@WhyNotHugo
Copy link
Contributor Author

Indeed it is, thanks.

@newpavlov
Copy link
Member

newpavlov commented Oct 4, 2023

We do not rely on the hermit-abi crate, so I think it would be better to link the relevant source code directly.

@josephlr
Copy link
Member

josephlr commented Oct 4, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants