Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should BootdevTag header tag be set to TagType::Bootdev ? #243

Open
jr-oss opened this issue Oct 11, 2024 · 2 comments
Open

Should BootdevTag header tag be set to TagType::Bootdev ? #243

jr-oss opened this issue Oct 11, 2024 · 2 comments

Comments

@jr-oss
Copy link

jr-oss commented Oct 11, 2024

I noticed this by coincidence and wondered whether the implementation is correct or a copy-paste error.

In bootdev.rs the header tag is set to TagType::Apm

header: TagHeader::new(TagType::Apm, mem::size_of::<Self>() as u32),

https://github.com/rust-osdev/multiboot2/blob/main/multiboot2/src/bootdev.rs#L22

Other tag implementations use Self::ID, which would be TagType::Bootdev for BootdevTag

@phip1611
Copy link
Collaborator

Great catch! Copy and paste error.. Thanks! Do you want to set up a PR?

@jr-oss
Copy link
Author

jr-oss commented Oct 11, 2024

I don't have a fork of multiboot2 and currently no planned project where I would use it.
If you could fix it in your copy, that would be nice.
Thanks,
Ralf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants