Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Officially deprecate Saturating #255

Open
benluelo opened this issue Jan 29, 2023 · 2 comments
Open

Officially deprecate Saturating #255

benluelo opened this issue Jan 29, 2023 · 2 comments

Comments

@benluelo
Copy link

The Saturating trait was deprecated here: 86c3126, but not officially (i.e. no #[deprecated, reason = "..."] attribute). Is there a reason for this? Would it be possible to do this?
@benluelo
Copy link
Author

Possibly related to #47, although I don't think that deprecating a trait is a breaking change

@benluelo benluelo mentioned this issue Jan 29, 2023
Open
@cuviper
Copy link
Member

cuviper commented Feb 10, 2023 •
edited
Loading

It's unfortunately tied to the PrimInt trait, as mentioned in #165 (comment). For that reason, I think a "soft" deprecation is better so folks don't have to squash a warning they can't otherwise avoid. There's also no inherent disadvantage to using Saturating -- it's just not consistent with how we did Checked* and Wrapping* traits.

Deprecation is not a breaking change though, you're right about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuviper @benluelo