-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Float trait depend on FloatConst. #20
Comments
It's a breaking change to extend a trait that way. Ideally, we might not have made For your own crates, you could create a local meta-trait that requires the |
Yeah. That's just a paper cut and I totally understand if it isn't worth making a breaking change just for that. If there's any plan to do a breaking change for whatever other reason It would be great to take this occasion to consolidate more features into the Float trait. |
I'm considering a semver bump for #16, but only to tweak features, not any breaking API change. But we can keep this issue for some future API cleanup. |
I've decided to limit the clutter of |
In my (arguably limited) experience with using the num traits,
FloatConst
is most of the time used along withFloat
. It would simplify a lot of type signatures if theFloat
trait bound impliedFloatConst
.I'll happily submit a PR if the idea is sound.
The text was updated successfully, but these errors were encountered: