-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Rename Complex{32,64} to ComplexF{32,64} #77
Comments
Do you have any links discussing this change for Julia? The master branch could currently accept breaking changes for the upcoming 0.3. However, this request doesn't have to be a breaking change if we also keep the existing names, just IMO these names have limited benefit already -- when you're writing See also #21 that wants really short names like |
I think the PR originally only removed/deprecated the old aliases (JuliaLang/julia#24647 (comment)), and then it was modified to add the |
Given the large amount of existing uses, I think even deprecation would be too much churn. |
This proposal would involves breaking changes and it is also a bit of personal opinion, so feel free to close it.
The names
Complex32
orComplex64
may be confusing for some users, because it might mean "a complex of 32/64 bits in total" or "a complex formed by two 32/64 bit floats".For example, numpy has
complex64
(2 x 32) andcomplex128
(2 x 64). Pre-1.0 Julia also hadComplex64
andComplex128
.In Julia 1.0 they decided to take the approach of using
ComplexF32
andComplexF64
, which, in my opinion, it specifies more clearly "a complex formed by two 32/64 bit floats". This naming also has the advantage of remarking that they use float as number format.The text was updated successfully, but these errors were encountered: