Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[track_caller] judiciously #972

Closed
bluss opened this issue Apr 6, 2021 · 1 comment · Fixed by #975
Closed

Add #[track_caller] judiciously #972

bluss opened this issue Apr 6, 2021 · 1 comment · Fixed by #975
Labels
enhancement good first issue A good issue to start contributing to ndarray!

Comments

@bluss
Copy link
Member

bluss commented Apr 6, 2021

Add #[track_caller] to some panicking methods. Slicing methods seem the most prudent (Index/Mut does not apply, sorry).

Needs benchmarks to investigate impact, preferably holistic benchmarks.
@bluss bluss added enhancement good first issue A good issue to start contributing to ndarray! labels Apr 6, 2021
@bluss bluss mentioned this issue Apr 6, 2021
Open
31 tasks
@xd009642
Copy link
Contributor

xd009642 commented Apr 7, 2021

I started work on this in #975

@bluss bluss mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue A good issue to start contributing to ndarray!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Track-caller panics xd009642/ndarray
2 participants
@bluss @xd009642