-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary bindings for target_arch = "armv7" #10
Comments
maybe one is for thumb instructions and the other for the regular arm instructions, but not sure |
Rust:
https://forge.rust-lang.org/release/platform-support.html Android NDK:
https://developer.android.com/ndk/guides/abis I guess that generated bindings for all 32-bit ARMs will be the same. |
target_arch = "x86" https://doc.rust-lang.org/reference/conditional-compilation.html#target_arch |
I look at the compiler specs, the arch and data layout actually is same for all 32-bit ARMs:
|
As I know in rust
target_arch = "arm"
actually corresponding to armv7, so second bindings completely useless.https://github.com/rust-windowing/android-ndk-rs/blob/a8ddfa4f7b510923cd69ded0f7e8492711b0af88/android-ndk-sys/src/lib.rs#L21-L28
Fix me if I'm wrong.
The text was updated successfully, but these errors were encountered: