Emit lints using a diagnostic builder #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xFrednet
added
C-enhancement
xFrednet
force-pushed
the
047-diagnostics
branch
from
fde8fa1 to
77972c0
Compare
|
I've rebased on master, after the nightly bump 🙃 There was a small conflict, but nothing changed :) |
Niki4tap
reviewed
Mar 15, 2023
Comment on lines
23
to
28
| warning: a field named `foo`, consider using a more meaningful name | ||
| --> $DIR/foo_items.rs:7:9 | ||
| | | ||
| 7 | foo: i32, | ||
| | ^^^^^^^^ | ||
|
|
There was a problem hiding this comment.
Not sure why this lint went away, maybe try_to_hir_id_from_emission_node is failing for FieldId?
|
Thank you for the review. ❤️ I had a busy week and now I'm catching up with all the fires I left burning. I'll probably get to this on the weekend. 🙃 |
Co-authored-by: Niki4tap <[email protected]> I should almost create an alias for this specific message
|
The PR should be ready now. I'll probably do some cleanup and maintenance now, to get back into the flow, after a short break :) |
xFrednet
force-pushed
the
047-diagnostics
branch
from
c2c40f9 to
3647b8c
Compare
|
Nice, I left some things too, will try to come back soon bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 4, 2023
136: Test: Use `emit_lint` instead of `println!` in tests r=xFrednet a=xFrednet Follow up of #121 Not much more to say. I'll r+ this directly, as these are automatically generated and would be a pain to review. r? `@ghost` Co-authored-by: xFrednet <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jun 4, 2023
136: Test: Use `emit_lint` instead of `println!` in tests r=xFrednet a=xFrednet Follow up of #121 Not much more to say. I'll r+ this directly, as these are automatically generated and would be a pain to review. r? `@ghost` Co-authored-by: xFrednet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
DiagnosticBuilderto the API to create beautiful diagnostics with help and note messages. This will also allow us to include the expression span, in the print tests. Generally, I'm pretty happy with the concept :)Adding new context callbacks to the API currently requires a lot of boilerplate code. I doubt that we can avoid that right now, but I'll try to look at options to generate a part of it. That would at least help with the implementation and review part.
r? @Niki4tap Sorry for requesting this review direction after the last one. You are welcome to take your time or pass the review if you don't have time. It's also totally fine, if you just review the API and doc changes. The backend is mostly verified by the tests :)
Closes #47
Closes #92 (This PR adds the
id()andspan()method toStmtKind)