Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic customization #76

Closed
Niki4tap opened this issue Jan 5, 2023 · 3 comments
Closed

Diagnostic customization #76

Niki4tap opened this issue Jan 5, 2023 · 3 comments
Labels
A-api Area: Stable API C-enhancement Category: New feature or request S-duplicate Status: This issue or pull request already exists
Milestone

Comments

@Niki4tap
Copy link
Member

Niki4tap commented Jan 5, 2023

Rustc has a good API for this that clippy uses: https://doc.rust-lang.org/stable/nightly-rustc/rustc_errors/struct.DiagnosticBuilder.html

Marker should probably have something like this too :)

@xFrednet
Copy link
Member

xFrednet commented Jan 5, 2023

Agreed, related to: #47

We should be careful, to decide which API we want to provide since we'll require all backends to support that. On the other hand there is currently only rustc and RA which support the same things

@xFrednet xFrednet added C-enhancement Category: New feature or request A-api Area: Stable API labels Jan 5, 2023
@xFrednet xFrednet added this to the v0.0.1 milestone Jan 5, 2023
@Niki4tap
Copy link
Member Author

Niki4tap commented Jan 6, 2023

Oh, hmm, the issue you linked seems nearly identical, somehow overlooked it, should I close this in favor of #47?

@xFrednet
Copy link
Member

xFrednet commented Jan 6, 2023

Yeah, I'll copy my comment over to that one :)

@xFrednet xFrednet closed this as completed Jan 6, 2023
@xFrednet xFrednet added the S-duplicate Status: This issue or pull request already exists label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-api Area: Stable API C-enhancement Category: New feature or request S-duplicate Status: This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants