Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Guide prescriptions on ABI explicitness #199

Open
calebcartwright opened this issue Oct 30, 2024 · 0 comments
Open

Style Guide prescriptions on ABI explicitness #199

calebcartwright opened this issue Oct 30, 2024 · 0 comments

Comments

@calebcartwright
Copy link
Member

rust-lang/rfcs#3722 seems likely to land albeit for some future edition beyond 2024, and when it does I would propose we remove the existing ABI prescriptions from the Style Guide text

Formatters (at least rustfmt) do not necessarily have the relevant context to know whether formatting changes that involved the ABI would be semantics preserving, and the behavior that matched the "always be explicit" rule in the Style Guide did cause a couple of issues over the years (e.g. rust-lang/rustfmt#2908)

Once rust-lang/rfcs#3722 is enacted I think rustfmt should fallback to just maintaining ABI as it exists within the AST, and leave the consideration of whether an ABI has a default and/or is required as a lang item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant