Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize cmpxchg16b #827

Closed
sfackler opened this issue Nov 21, 2019 · 3 comments · Fixed by #1358
Closed

Stabilize cmpxchg16b #827

sfackler opened this issue Nov 21, 2019 · 3 comments · Fixed by #1358

Comments

@sfackler
Copy link
Member

Is anything holding up stabilization of double-wide CAS? It doesn't seem so from some searching.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 21, 2019

Weird, I thought I saw a stabilization PR for this one somewhere. Stabilizing this sounds good to me.

@thomcc
Copy link
Member

thomcc commented Dec 10, 2021

Is there some story here? I've always assumed that it was intentionally left unstabilized in order to avoid stabilizing 128 bit atomics in some form prior to Atomic[UI]128.

However, with asm! stabilization on the way, this ship will sail, so I don't a reason not to.

@Amanieu
Copy link
Member

Amanieu commented Dec 11, 2021

I'm happy to accept a PR for stabilizing it. I only have one minor nit about the implementation: the ud2 should be changed to a normal panic.

Amanieu pushed a commit that referenced this issue Jan 5, 2023
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 28, 2023
Stabilize cmpxchg16b_target_feature

Tracking issue for target features
+ rust-lang#44839

stdarch issue
+ rust-lang/stdarch#827

stdarch PR
+ rust-lang/stdarch#1358

reference PR
+ rust-lang/reference#1331

It's my first time contributing to rust-lang/rust. Please tell me if I missed something.
saethlin pushed a commit to saethlin/miri that referenced this issue Mar 5, 2023
Stabilize cmpxchg16b_target_feature

Tracking issue for target features
+ #44839

stdarch issue
+ rust-lang/stdarch#827

stdarch PR
+ rust-lang/stdarch#1358

reference PR
+ rust-lang/reference#1331

It's my first time contributing to rust-lang/rust. Please tell me if I missed something.
thomcc pushed a commit to tcdi/postgrestd that referenced this issue May 31, 2023
Stabilize cmpxchg16b_target_feature

Tracking issue for target features
+ #44839

stdarch issue
+ rust-lang/stdarch#827

stdarch PR
+ rust-lang/stdarch#1358

reference PR
+ rust-lang/reference#1331

It's my first time contributing to rust-lang/rust. Please tell me if I missed something.
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 20, 2024
Stabilize cmpxchg16b_target_feature

Tracking issue for target features
+ #44839

stdarch issue
+ rust-lang/stdarch#827

stdarch PR
+ rust-lang/stdarch#1358

reference PR
+ rust-lang/reference#1331

It's my first time contributing to rust-lang/rust. Please tell me if I missed something.
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
Stabilize cmpxchg16b_target_feature

Tracking issue for target features
+ #44839

stdarch issue
+ rust-lang/stdarch#827

stdarch PR
+ rust-lang/stdarch#1358

reference PR
+ rust-lang/reference#1331

It's my first time contributing to rust-lang/rust. Please tell me if I missed something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants