-
Notifications
You must be signed in to change notification settings - Fork 45
Attempt to fix issue 43 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pietroalbini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Left some feedback.
|
This may be reimplementing https://crates.io/crates/fs-err |
|
Did't know about |
|
Though it might be reasonable to also get better errors for other Filesystem operations using |
|
Opened PR #47 to expand on this using |
|
I feel like this approach is better than #47: bringing another dependency just for this is not really needed. Thanks for working on the PRs! Merging. |
maps error for all remove_dir_all calls where the result is not ignored (all but one) to the added Custom error type to also display the directory path
EDIT: also do this for file removals