Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override remove from inner directories lies about successful removal #339

Closed
pravic opened this issue Apr 18, 2016 · 6 comments
Closed

Override remove from inner directories lies about successful removal #339

pravic opened this issue Apr 18, 2016 · 6 comments

Comments

@pravic
Copy link

pravic commented Apr 18, 2016

t:\hello-rs\windows\target\release>rustup override list
T:\hello-rs\windows nightly-x86_64-pc-windows-msvc

t:\hello-rs\windows\target\release>rustup override remove
info: override toolchain for 't:\hello-rs\windows\target\release' removed
t:\hello-rs\windows\target\release>rustup override remove
info: override toolchain for 't:\hello-rs\windows\target\release' removed

t:\hello-rs\windows\target\release>cd ..
t:\hello-rs\windows\target>rustup override remove
info: override toolchain for 't:\hello-rs\windows\target' removed
t:\hello-rs\windows\target>rustup override remove
info: override toolchain for 't:\hello-rs\windows\target' removed

t:\hello-rs\windows\target>cd ..
t:\hello-rs\windows>rustup override remove
info: override toolchain for 't:\hello-rs\windows' removed
t:\hello-rs\windows>rustup override remove
info: no override toolchain for 't:\hello-rs\windows'

Meta:

rustup 0.1.6

@brson
Copy link
Contributor

brson commented Apr 19, 2016

Thanks for the report. IMO calling rustup override remove from a subdirectory of an override should report an error, not try to remove the parent directory override.

@pravic
Copy link
Author

pravic commented Apr 20, 2016

should report an error, not try to remove the parent directory override.

+1

@Diggsey
Copy link
Contributor

Diggsey commented May 8, 2016

I think this will be fixed as a side effect #420

@pravic
Copy link
Author

pravic commented May 16, 2016

Nope, it was not fixed still (0.1.12).

@Diggsey
Copy link
Contributor

Diggsey commented May 16, 2016

@pravic #420 hasn't been merged yet ;)

@brson
Copy link
Contributor

brson commented Jun 23, 2016

Fixed.

@brson brson closed this as completed Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants