Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latent file removal bug #2734

Closed
rbtcollins opened this issue Apr 26, 2021 · 1 comment · Fixed by #2752
Closed

latent file removal bug #2734

rbtcollins opened this issue Apr 26, 2021 · 1 comment · Fixed by #2752
Labels
bug E-easy E-mentor help wanted

Comments

@rbtcollins
Copy link
Contributor

I just noticed that ensure_file_removed doesn't have the retry logic that remove_file does (both in utils.rs: the difference between them is solely that a file-not-found error is ignored by ensure-file-removed; so we should apply the retry logic - in fact we should just layer ensure_file_removed on remove_file.
@joshrotenberg
Copy link
Contributor

I'm gonna give this one a shot if that's cool.

@joshrotenberg joshrotenberg mentioned this issue May 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug E-easy E-mentor help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use utils::remove_file in utils::ensure_file_removed joshrotenberg/rustup
2 participants
@joshrotenberg @rbtcollins