-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"error: component download failed" #2169
Comments
If it was retrying it would indicate such. As such I can only conclude that a 'connection reset by peer' error is somehow not being communicated to The download loop is here: https://github.com/rust-lang/rustup/blob/master/src/dist/manifestation.rs#L177 it currently doesn't insert any delays on the basis that most failure modes warrant an immediate retry (or likely won't be resolved by retrying anyway -- such as a loss of connectivity). My guess is that the |
Unfortunately I don’t know how to reliably reproduce this error. However I see that the |
Oh never mind, |
The |
Okay, so after some more research, I think this ends up as |
I've been back over this and cannot see why it would not have been retrying unless the rustup version you had was too old. Perhaps add a 'rustup --version` to your CI script to be sure it's at least 1.21 since that's where retry logic was released. |
Ah! Good to know. The log in the issue description is for CI task https://community-tc.services.mozilla.com/tasks/T10RQXfSRCCODoDHP5bkAA/runs/0 which runs in a Docker image build by task https://community-tc.services.mozilla.com/tasks/H0g0jHrZRGmozGe41fT2zg which ran on 2019-12-10, installing the then-current rustup with We’ve since upgraded to 1.21, and as far as I know haven’t seen this kind of download error again. I’ll close this as fixed in 1.21 now, and reopen if we ever observe this again. Thanks for your help! |
Thanks Simon. |
Describe the problem you are trying to solve
In every build job on Servo’s CI, rustup starts by downloading the Nightly pinned in the repository’s
rust-toolchain
file. Sometimes this fails:https://community-tc.services.mozilla.com/tasks/T10RQXfSRCCODoDHP5bkAA/runs/0/logs/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FT10RQXfSRCCODoDHP5bkAA%2Fruns%2F0%2Fartifacts%2Fpublic%2Flogs%2Flive.log#L395
Describe the solution you'd like
I was going to suggest making rustup automatically retry downloads a few times, but GitHub’s "might be related" issues suggestions lead me to #1667, then #2121, then https://github.com/rust-lang/rustup/blob/master/CONTRIBUTING.md#rustup_max_retries
Does the latter mean that the download already failed four times before a visible
error: component download failed
is emitted?Is there a time delay between these retries? What would you think of adding one, perhaps with exponential back-off?
The text was updated successfully, but these errors were encountered: