Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solutions for try_from_into and from_str are same #392

Closed
ikar49 opened this issue May 12, 2020 · 2 comments · Fixed by #393
Closed

Solutions for try_from_into and from_str are same #392

ikar49 opened this issue May 12, 2020 · 2 comments · Fixed by #393

Comments

@ikar49
Copy link
Contributor

ikar49 commented May 12, 2020

I'm just copy-paste my code from fisrt exercise to second and it's ok.
May be should combine them into one?

@AbdouSeck
Copy link
Contributor

Hi @ikar49,

Thanks for your comments. TryFrom and FromStr are two different traits, although the former could everything that the latter does. For the sake of completeness, combining the two would be misleading. What's possible is changing the code in either one of them to make the exercises different.

What do you think? If that sounds good to you, we'd be more than happy to have you implement it.

Thanks!

Abdou

@ikar49
Copy link
Contributor Author

ikar49 commented May 12, 2020

Hm, your idea is better than mine.
So, I'm newbie, but i'll try :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants