Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support f16 and f128 #461

Open
tgross35 opened this issue Mar 1, 2024 · 4 comments
Open

Support f16 and f128 #461

tgross35 opened this issue Mar 1, 2024 · 4 comments

Comments

@tgross35
Copy link
Contributor

tgross35 commented Mar 1, 2024

As of rust-lang/rust#121728, the backends now have stubs for f16 and f128: https://github.com/rust-lang/rust/blob/6cbf0926d54c80ea6d15df333be9281f65bbeb36/compiler/rustc_codegen_gcc/src/type_.rs#L123-L137.

It will be a while before these codepaths can even be exercised since the frontend isn't hooked up yet, (frontend is done now) but at some point this should be changed to either gracefully fail or do the right thing.

@tgross35
Copy link
Contributor Author

Hey @zedar I saw you did rust-lang/gcc#47 and rust-lang/gccjit.rs#33 for this. Is anything else needed in the GCC backend, or do the unimplemented!s at

fn type_f16(&self) -> Type<'gcc> {
unimplemented!("f16_f128")
}
fn type_f32(&self) -> Type<'gcc> {
self.float_type
}
fn type_f64(&self) -> Type<'gcc> {
self.double_type
}
fn type_f128(&self) -> Type<'gcc> {
unimplemented!("f16_f128")
}
just need to be updated?

@antoyo
Copy link
Contributor

antoyo commented Jun 25, 2024

The support was merged recently (those were updated and are not unimplemented!() anymore).
It might require a sync for it to work properly, but the current sync is very difficult to do, so it will take more time before it's ready.

@tgross35
Copy link
Contributor Author

Oh I see they were done in antoyo#17, awesome!

I don't have any need for it, just been chasing down the f16_f128 FIXMEs and unimplemented!s.

@tgross35
Copy link
Contributor Author

(chances are you know this already, but Miri is using https://github.com/josh-project/josh for supposedly easier syncs, I think Clippy is looking to switch to it too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants