Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiccup in 2024-09-23 triage: curl from parent had only prefix of data #1982

Open
pnkfelix opened this issue Oct 1, 2024 · 1 comment
Open

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Oct 1, 2024

The usual triage process is to issue a curl command like curl "https://perf.rust-lang.org/perf/triage?start=$PARENT", where $PARENT is found by looking at the end commit for the previous week's triage.

However, back on 2024-09-23, that methodology yielded a subset of the expected data.

In particular, the result from doing:

curl "https://perf.rust-lang.org/perf/triage?start=170d6cb845c8c3f0dcec5cdd4210df9ecf990244"

is a report that covers the commit range: Revision range: 170d6cb8..749f80ab, a range covering just 2024-09-16 through 2024-09-19.

Luckily, @Kobzol pointed this out to me (I was driving 2024-09-23 triage) and so I ended up working around the issue (by manually looking at the history, determining that commit 506f22b4663f3e756e1e6a4f66c6309fdc00819c looked like the next merge from bors, using that latter commit as the basis for a second curl query, and then manually combining the two reports into one semi-unified report).

But it would be good to understand why this happened, and try to prevent it.

@pnkfelix
Copy link
Member Author

pnkfelix commented Oct 1, 2024

@Kobzol 's current theory is that this might have an artifact of adding the nalgebra benchmark to the benchmark suite back in PR #1977.

(The idea being that nalgebra didn't have historical data. And that for some reason causes the truncation of the report.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant