Implement Clone and DeepClone for extra::time::{Tm, Timespec} #8555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Aug 18, 2013
I need `Clone` for `Tm` for my latest work on [rust-http](https://github.com/chris-morgan/rust-http) (static typing for headers, and headers like `Date` are a time), so here it is. @huonw recommended deriving DeepClone while I was at it. I also had to implement `DeepClone` for `~str` to get a derived implementation of `DeepClone` for `Tm`; I did `@str` while I was at it, for consistency.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 31, 2023
new lint: [`readonly_write_lock`] Closes rust-lang#8555 A new lint that catches `RwLock::write` calls to acquire a write lock only to read from it and not actually do any writes (mutations). changelog: new lint: [`readonly_write_lock`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need
CloneforTmfor my latest work on rust-http (static typing for headers, and headers likeDateare a time), so here it is.@huonw recommended deriving DeepClone while I was at it.
I also had to implement
DeepClonefor~strto get a derived implementation ofDeepCloneforTm; I did@strwhile I was at it, for consistency.