Rollup of 6 pull requests #85057
Merged
Rollup of 6 pull requests #85057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It's used exactly once, so it's trivial to replace - It doesn't match the normal convention for containers: normally `get()` returns and option and indexing panics. Instead `get()` panicked and there's no indexing operation available.
It's more explicit and allows platforms to optimize the existence check.
…struct, r=jackh726 Improve diagnostics for functions in `struct` definitions Tries to implement rust-lang#76421. This is probably going to need unit tests, but I wanted to hear from review all the cases tests should cover. I'd like to follow up with the "mechanically applicable suggestion here that adds an impl block" step, but I'd need guidance. My idea for now would be to try to parse a function, and if that succeeds, create a dummy `ast::Item` impl block to then format it using `pprust`. Would that be a viable approach? Is there a better alternative? r? `@matklad` cc `@estebank`
Remove SpanInterner::get - It's used exactly once, so it's trivial to replace - It doesn't match the normal convention for containers: normally `get()` returns an option and indexing panics. Instead `SpanInterner::get()` panics and there's no indexing operation available.
fix null pointer error messages I got the `match` in rust-lang#84972 wrong, this fixes that. Also avoid redundant "inbounds test failed:" prefix. Should fix rust-lang#85027 r? `@oli-obk`
…doc-gui-failure, r=Mark-Simulacrum Don't stop running rustdoc-gui tests at first failure I just realized that before this PR, the rustdoc-gui test suite was stopping at the first failure, which isn't very convenient. All tests are now running and if one failed, it returns an error at the end once all tests have run. r? `@Mark-Simulacrum`
Use `path.exists()` instead of `fs::metadata(path).is_ok()` It's more explicit and potentially allows platforms to optimize the existence check.
rustdoc: Link to the docs on namespaces when an unknown disambiguator is found This was reverted in rust-lang#84950; this re-lands the changes, but without different behavior depending on the channel. r? `@camelid` cc `@pietroalbini`
|
@bors r+ rollup=never p=5 |
|
📌 Commit 8852317 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
structdefinitions #76808 (Improve diagnostics for functions instructdefinitions)path.exists()instead offs::metadata(path).is_ok()#85044 (Usepath.exists()instead offs::metadata(path).is_ok())Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup