Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash parent ExpnData #75134

Merged
merged 1 commit into from
Aug 9, 2020
Merged

Hash parent ExpnData #75134

merged 1 commit into from
Aug 9, 2020

Conversation

Aaron1011
Copy link
Member

@Aaron1011 Aaron1011 commented Aug 4, 2020 •
edited by petrochenkov
Loading

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2020
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Aug 4, 2020

⌛ Trying commit 1f63a6a with merge b68f54c3db341094fe68cb57a71def8afce8fafb...

@bors
Copy link
Contributor

bors commented Aug 4, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: b68f54c3db341094fe68cb57a71def8afce8fafb (b68f54c3db341094fe68cb57a71def8afce8fafb)

@rust-timer
Copy link
Collaborator

Queued b68f54c3db341094fe68cb57a71def8afce8fafb with parent 80f84eb, future comparison URL.

@petrochenkov
Copy link
Contributor

r? @petrochenkov

@rust-highfive rust-highfive assigned petrochenkov and unassigned varkor Aug 4, 2020
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b68f54c3db341094fe68cb57a71def8afce8fafb): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 9, 2020

📌 Commit 1f63a6a has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2020
@bors
Copy link
Contributor

bors commented Aug 9, 2020

⌛ Testing commit 1f63a6a with merge 543f03d...

@bors
Copy link
Contributor

bors commented Aug 9, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: petrochenkov
Pushing 543f03d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 9, 2020
@bors bors merged commit 543f03d into rust-lang:master Aug 9, 2020
@ecstatic-morse
Copy link
Contributor

Final perf results. A very small regression in instruction counts, as expected.

@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Aaron1011 @rust-highfive @rust-timer @bors @petrochenkov @ecstatic-morse @cuviper @varkor