Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize span hygiene data #72121

Merged
merged 9 commits into from
Jul 27, 2020
Merged

Serialize span hygiene data #72121

merged 9 commits into from
Jul 27, 2020

Commits on Jul 26, 2020

  1. Hygiene serialization implementation

    @Aaron1011
    Aaron1011 committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    0caebfa View commit details
    Browse the repository at this point in the history

  2. Add test for use of $crate in nested foreign macro_rules!

    @Aaron1011
    Aaron1011 committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    5cd1b5d View commit details
    Browse the repository at this point in the history

  3. Add test for serializing hygiene *into* a proc-macro crate 

    This is a very obscure corner case, and should never be hit in practice.
    @Aaron1011
    Aaron1011 committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    979dd77 View commit details
    Browse the repository at this point in the history

  4. Ignore orig_id for stable hashing 

    This does not affect semantic equality, and was causing an enormous
number of Span hash invalidations.
    @Aaron1011
    Aaron1011 committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    dc21612 View commit details
    Browse the repository at this point in the history

  5. Add test for hygiene caching issue

    @Aaron1011
    Aaron1011 committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    7e0d3fd View commit details
    Browse the repository at this point in the history

  6. Properly reset orig_id when loading from incremental cache

    @Aaron1011
    Aaron1011 committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    cf7bef3 View commit details
    Browse the repository at this point in the history

  7. Share serialization optimization between incr and metadata

    @Aaron1011
    Aaron1011 committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    f622f45 View commit details
    Browse the repository at this point in the history

  8. Remove explicit extern crate from proc-macro test 

    We only want to load this auxiliary crate from a proc-macro, so that it
only ever needs to get built for the host platform.
    @Aaron1011
    Aaron1011 committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    768803c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Normalize the test output of hygiene-related tests 

    A raw SyntaxContext id is implicitly dependent on the target platform,
since libstd and libcore have platform-dependent #[cfg]s which affect
which macros are invoked. As a result, we must strip out any
SyntaxContext ids from test output to ensure that the captured stdout is
not platform-dependent.
    @Aaron1011
    Aaron1011 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    f7235a8 View commit details
    Browse the repository at this point in the history