Implement RFC 2707 + Parser recovery for range patterns#62550

Merged

bors merged 34 commits intorust-lang:masterfrom Centril:rest-patterns

Jul 28, 2019

+1,546-675

Commits on Jul 28, 2019

Add 'ast::PatKind::Rest'.
Centril
committed
Introduce 'ast::Pat::is_rest(&self) -> bool'.
Centril
committed
Adjust 'ast::PatKind::{TupleStruct,Tuple,Slice}'.
Centril
committed
Adjust feature gating of subslice patterns accordingly.
Centril
committed
Adjust pretty printing accordingly.
Centril
committed
Adjust and document 'Pat::to_ty' accordingly.
Centril
committed
Adjust lowering of Tuple/TupleStruct patterns.
Centril
committed
Adjust lowering of Slice patterns.
Centril
committed
Cleanup parse_seq_* methods + record trailing separators.
Centril
committed
Add more parse_*_seq methods for code reuse.
Centril
committed
Cleanup using the new parse_*_seq methods.
Centril
committed
Adjust parsing of Slice, Tuple, TupleStruct patterns.
Centril
committed
Recover on '..X' / '..=X' / '...X' range patterns.
Centril
committed
Recover on 'X..' / 'X..=' / 'X...' range patterns.
Centril
committed
Update tests wrt. recovery of range patterns.
Centril
committed
And also --bless those recovery tests.
Centril
committed
Test parsing and recovery of all sorts of range patterns.
Centril
committed
Use new 'p @ ..' syntax in tests.
Centril
committed
--bless tests due to new subslice syntax.
Centril
committed
Intersection patterns 'p1 @ p2' are not supported.
Centril
committed
Account for better recovery in two cases.
Centril
committed
(pat, ..,) is now syntactically legal.
Centril
committed
Win some lose some; Unfortunately we lost recovery in one case.
Centril
committed
Update unstable book wrt. subslice patterns.
Centril
committed
Adjust documentation in HAIR.
Centril
committed
Get out of bootstrapping pickle.
Centril
committed
--bless tests after rebase.
Centril
committed
Update error_codes.rs with new subslice syntax.
Centril
committed
Use AstP more in lowering.
Centril
committed
Address comments in lowering + parsing.
Centril
committed
Address comments re. off-topic errors.
Centril
committed
Add exceptions for ExprKind::Err/TyKind::Error.
Centril
committed
And --bless tests accordingly for those exceptions.
Centril
committed
borrowck-describe-lvalue: --bless --compare-mode=nll.
Centril
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement RFC 2707 + Parser recovery for range patterns#62550

Commits on Jul 28, 2019

Add 'ast::PatKind::Rest'.

Introduce 'ast::Pat::is_rest(&self) -> bool'.

Adjust 'ast::PatKind::{TupleStruct,Tuple,Slice}'.

Adjust feature gating of subslice patterns accordingly.

Adjust pretty printing accordingly.

Adjust and document 'Pat::to_ty' accordingly.

Adjust lowering of Tuple/TupleStruct patterns.

Adjust lowering of Slice patterns.

Cleanup parse_seq_* methods + record trailing separators.

Add more parse_*_seq methods for code reuse.

Cleanup using the new parse_*_seq methods.

Adjust parsing of Slice, Tuple, TupleStruct patterns.

Recover on '..X' / '..=X' / '...X' range patterns.

Recover on 'X..' / 'X..=' / 'X...' range patterns.

Update tests wrt. recovery of range patterns.

And also --bless those recovery tests.

Test parsing and recovery of all sorts of range patterns.

Use new 'p @ ..' syntax in tests.

--bless tests due to new subslice syntax.

Intersection patterns 'p1 @ p2' are not supported.

Account for better recovery in two cases.

(pat, ..,) is now syntactically legal.

Win some lose some; Unfortunately we lost recovery in one case.

Update unstable book wrt. subslice patterns.

Adjust documentation in HAIR.

Get out of bootstrapping pickle.

--bless tests after rebase.

Update error_codes.rs with new subslice syntax.

Use AstP more in lowering.

Address comments in lowering + parsing.

Address comments re. off-topic errors.

Add exceptions for ExprKind::Err/TyKind::Error.

And --bless tests accordingly for those exceptions.

borrowck-describe-lvalue: --bless --compare-mode=nll.