Use fstatat64 where available #51785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully this will fix #51717 (comment). |
pietroalbini
added
beta-nominated
|
@bors r+ p=50 This is a relatively critical bug; increasing priority. |
|
📌 Commit 65d31d7 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added
the
beta-accepted
bors
added a commit
that referenced
this pull request
Jun 25, 2018
Use fstatat64 where available None
cuviper
added a commit
to cuviper/rust
that referenced
this pull request
Jun 25, 2018
In effect, these just casted `&mut stat64` to `*mut stat64`, twice. That's harmless, but it masked a problem when this was copied to new code calling `fstatat`, which takes a pointer to `struct stat`. That will be fixed by rust-lang#51785, but let's remove the unnecessary casts here too.
|
@cuviper Can you prepare a beta backport? |
pietroalbini
removed
the
beta-nominated
|
☀️ Test successful - status-appveyor, status-travis |
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Jun 26, 2018
…ulacrum Remove unnecessary stat64 pointer casts In effect, these just casted `&mut stat64` to `*mut stat64`, twice. That's harmless, but it masked a problem when this was copied to new code calling `fstatat`, which takes a pointer to `struct stat`. That will be fixed by rust-lang#51785, but let's remove the unnecessary casts here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.