change MIR dump filenames from rustc.nodeN... to rustc.<DefPath>
#45757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
reviewed
Nov 4, 2017
src/librustc/hir/map/definitions.rs
Outdated
| write!(s, ".{}", component.data.as_interned_str()).unwrap(); | ||
| } else { | ||
| write!(s, | ||
| ".{}[{}]", |
There was a problem hiding this comment.
Nit: maybe use -? I sort of like that the . in the current filename allows us to "group" (e.g., rustc.foo-bar.before.mir can be split on . to get out the various bits of information about what this is a dump of)
kennytm
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 4a482e9 has been approved by |
kennytm
added
S-waiting-on-bors
|
@mikhail-m1 You may need a rebase since a new mir test ( |
mikhail-m1
force-pushed
the
change-mir-dump-filename
branch
from
4a482e9 to
0e5c95e
Compare
|
@bors r+ |
|
📌 Commit 0e5c95e has been approved by |
|
⌛ Testing commit 0e5c95e with merge bdb03322cb03b767b35f945799fdd30b065333ac... |
|
💔 Test failed - status-travis |
|
@bors retry — travis-ci/travis-ci#8728 |
bors
added a commit
that referenced
this pull request
Nov 9, 2017
…sakis change MIR dump filenames from `rustc.nodeN...` to `rustc.<DefPath>` r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis