Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fix for #34209 to beta #34964

Merged
merged 1 commit into from
Jul 21, 2016
Merged

Backport fix for #34209 to beta #34964

merged 1 commit into from
Jul 21, 2016

Conversation

petrochenkov
Copy link
Contributor

Closes #34929

r? @eddyb

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@eddyb eddyb added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 21, 2016
@eddyb
Copy link
Member

eddyb commented Jul 21, 2016

LGTM. cc @alexcrichton

@pnkfelix pnkfelix added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. and removed I-nominated labels Jul 21, 2016
@pnkfelix
Copy link
Member

accepted for beta!

@alexcrichton alexcrichton merged commit 62e48b9 into rust-lang:beta Jul 21, 2016
@alexcrichton alexcrichton mentioned this pull request Jul 21, 2016
Closed
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 21, 2016
@alexcrichton
Copy link
Member

Thanks @petrochenkov!

@petrochenkov petrochenkov deleted the beta branch September 21, 2016 20:02
pmatos pushed a commit to LinkiTools/rust that referenced this pull request Sep 27, 2016
@alexcrichton
Merge pull request rust-lang#34964 from petrochenkov/beta
bca1473 
Backport fix for rust-lang#34209 to beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petrochenkov @rust-highfive @eddyb @pnkfelix @alexcrichton