[RFC issue 1468] make some common traits object-safe #31193
Conversation
specifically: Clone, Default, From, Into, FromStr, One, Zero breakage: causes RFC 1214 and other WF warnings/errors [breaking-change]
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I'm confused -- do you really want to land this, or just want the results from a crater run? |
|
I think for now just the results of a crater run would inform the discussion on that issue. Certainly it would be nice for more things to be object-safe, but there was fallout even within the tests and compiler so it kinda seems like a non-starter unless we have super compelling reasons. |
Hmm, can you say more about this? In particular, if the trait can't actually be used with an object, then why would it be nice for it to be object safe? |
|
OK, well, I've kicked off a crater run (I don't think @brson saw the ping). I'll let you know what it says. |
|
Crater report: https://gist.github.com/nikomatsakis/6478dde577e9affd957d Summary: 3702 crates tested: 1984 working / 1160 broken / 305 regressed / 1 fixed / 252 unknown. |
This is a very dubious change but @eddyb was curious about the fallout. @brson crater this too?
cc rust-lang/rfcs#1468